Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix url arguments detection #494

Merged
merged 6 commits into from
Jan 24, 2024
Merged

Fix url arguments detection #494

merged 6 commits into from
Jan 24, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 22, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • Fix url argument detection. Previously" action=token&some=XXX has been wrong detect variable (was "some")
  • update packages in requirements.txt

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

babenek
babenek commented Jan 22, 2024
View reviewed changes
Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rollback after Samsung/CredData#69

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3057c3) 90.44% compared to head (6cffb1a) 90.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #494   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         127      127           
  Lines        4335     4335           
  Branches      695      695           
=======================================
  Hits         3921     3921           
  Misses        273      273           
  Partials      141      141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek mentioned this pull request Jan 23, 2024
Merged
@babenek babenek marked this pull request as ready for review January 23, 2024 15:57
@babenek babenek requested a review from a team as a code owner January 23, 2024 15:57
Yullia
Yullia approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

xDizzix
xDizzix approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babenek babenek merged commit 933a174 into Samsung:main Jan 24, 2024
29 checks passed
@babenek babenek deleted the fixvarpos branch January 24, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDizzix xDizzix xDizzix approved these changes

@Yullia Yullia Yullia approved these changes

@iuriimet iuriimet Awaiting requested review from iuriimet

@meanrin meanrin Awaiting requested review from meanrin

@Dmitriy-NK Dmitriy-NK Awaiting requested review from Dmitriy-NK

@csh519 csh519 Awaiting requested review from csh519

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@babenek @codecov-commenter @xDizzix @Yullia